[ https://issues.apache.org/jira/browse/YARN-8675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591716#comment-16591716 ]
Billie Rinaldi commented on YARN-8675: -------------------------------------- Thanks for the patch, [~suma.shivaprasad]! I think we should also remove the unused code that was setting a default hostname: [https://github.com/apache/hadoop/blob/cb21eaa026d80a2c9836030d959c0dd7f87c4d6b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/DockerLinuxContainerRuntime.java#L556-L565|https://github.com/apache/hadoop/blob/cb21eaa026d80a2c9836030d959c0dd7f87c4d6b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/DockerLinuxContainerRuntime.java#L556-L565,] and we'll no longer need the RegistryPathUtils import. Based on line 556, it looks like we should avoid setting the hostname when the provided value is empty, as well. > Setting hostname of docker container breaks with "host" networking mode for > Apps which do not run as a YARN service > ------------------------------------------------------------------------------------------------------------------- > > Key: YARN-8675 > URL: https://issues.apache.org/jira/browse/YARN-8675 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Yesha Vora > Assignee: Suma Shivaprasad > Priority: Major > Labels: Docker > Attachments: YARN-8675.1.patch > > > Applications like the Spark AM currently do not run as a YARN service and > setting hostname breaks driver/executor communication if docker version > >=1.13.1 , especially with wire-encryption turned on. > YARN-8027 sets the hostname if YARN DNS is enabled. But the cluster could > have a mix of YARN service/native Applications. > The proposal is to not set the hostname when "host" networking mode is > enabled. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org