[
https://issues.apache.org/jira/browse/YARN-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597383#comment-16597383
]
Szilard Nemeth commented on YARN-8621:
--------------------------------------
[~shuzirra]: Thanks for the review!
Some hints for the commiter review:
Since a huge code block was moved from {{TestRMWebServicesApps}} to
{{TestRMWebServicesAppAttempts}} and there are slight modifications in the
final version, I would diff the class body of {{TestRMWebServicesAppAttempts}}
with the original version of {{TestRMWebServicesApps}} to see the differences.
Similarly, I had to move a code block from
{{TestRMWebServicesAppsCustomResourceTypes}} to
{{TestRMWebServicesCustomResourceTypesCommons}}, so making a diff between the
new version of this class with {{TestRMWebServicesAppsCustomResourceTypes}}
makes sense.
The other diffs are easily visible from the patch.
> Add REST API tests for Resource Types fields for the apps/<appId> endpoint
> --------------------------------------------------------------------------
>
> Key: YARN-8621
> URL: https://issues.apache.org/jira/browse/YARN-8621
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-8621.001.patch, YARN-8621.002.patch
>
>
> This is a complement for YARN-7451 that already added unit tests for the apps
> and scheduler endpoints.
> The following API endpoints should be tested as well:
> /ws/v1/cluster/apps/<appid>
> -/ws/v1/cluster/apps/<appid>/appattempts-
> -/ws/v1/cluster/apps/<appid>/appattempts/<attemptid>-
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
