[
https://issues.apache.org/jira/browse/YARN-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13777082#comment-13777082
]
Ravi Prakash commented on YARN-90:
----------------------------------
Hi nijel!
Welcome to the community and thanks for your contribution. A few comments:
1. Nit: Some lines are over 80 characters long.
2. numFailures is never incremented any more when the directory fails. Thus
getNumFailures() would return the wrong result.
Could you please also tell us how you tested the patch? There seem to be a lot
of unit tests which use LocalDirsHandlerService. Did you run them all and
ensure that they still all pass?
Thanks again
> NodeManager should identify failed disks becoming good back again
> -----------------------------------------------------------------
>
> Key: YARN-90
> URL: https://issues.apache.org/jira/browse/YARN-90
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Ravi Gummadi
> Attachments: YARN-90.patch
>
>
> MAPREDUCE-3121 makes NodeManager identify disk failures. But once a disk goes
> down, it is marked as failed forever. To reuse that disk (after it becomes
> good), NodeManager needs restart. This JIRA is to improve NodeManager to
> reuse good disks(which could be bad some time back).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
