[ 
https://issues.apache.org/jira/browse/YARN-5592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605491#comment-16605491
 ] 

Sunil Govindan commented on YARN-5592:
--------------------------------------

Few comments on the design doc attached,

1. {{We can introduce a file named dymanic-resource-types.xml}} . This doesn't 
looks like a cleaner approach to me. We should use the existing 
resource-types.xml and add new types as desired. Once its loaded, yarn should 
auto detect whats new added and update internally the same.

2. {{We can introduce an option something like “-refreshResourceTypes”}} I am 
fine with such a CLI option to force YARN to fetch updated resource types. 
Naming seems a bit confusing which can be improved.

3. *Approach A:* is not good as its kills containers. As per me *Update 
existing resource types in RM (resource1)*, this is not an immediate use case, 
hence in first round lets skip this.

4. My 2 cents on removal of resource types. This is one of the complex 
operations. Some node may have this resource type, and some container may be 
running with this and some are waiting etc. Hence a removal of resource type 
cannot be done seemless. I think we should restart YARN ideally in such cases. 
[~leftnoteasy] [~cheersyang], what's ur thoughts on support removal of a 
resource types at run time from YARN?

> Add support for dynamic resource updates with multiple resource types
> ---------------------------------------------------------------------
>
>                 Key: YARN-5592
>                 URL: https://issues.apache.org/jira/browse/YARN-5592
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Varun Vasudev
>            Assignee: Manikandan R
>            Priority: Major
>         Attachments: YARN-5592-design-2.docx
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to