[
https://issues.apache.org/jira/browse/YARN-8468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617371#comment-16617371
]
Weiwei Yang edited comment on YARN-8468 at 9/17/18 11:00 AM:
-------------------------------------------------------------
Generally took a look, it seems good. But it would be helpful if [~bsteinbach]
can upload a up-to-date patch so I can apply to take a closer look. v12 patch
doesn't apply anymore.
Some comments:
1) There are too many checkstyle issues need to be fixed
2) Suggest to add a NPE check in case app is null in following changes in
PlacementConstraintProcessor
{code:java}
+ String queueName =
+ scheduler.getApplicationAttempt(appAttemptId).getQueueName();
+ Resource maxAllocation = scheduler.getMaximumResourceCapability(queueName);
{code}
Thanks
was (Author: cheersyang):
Generally took a look, it seems good. But it would be helpful if [~bsteinbach]
can upload a up-to-date patch so I can apply to take a closer look. v12 patch
doesn't apply anymore.
Some comments:
1) There are too many checkstyle issues need to be fixed
2) Suggest to add a NPE check in case app is null in following changes in
PlacementConstraintProcessor
{code}
+ String queueName =
+ scheduler.getApplicationAttempt(appAttemptId).getQueueName();
+ Resource maxAllocation = scheduler.getMaximumResourceCapability(queueName);
{code}
Thanks
> Limit container sizes per queue in FairScheduler
> ------------------------------------------------
>
> Key: YARN-8468
> URL: https://issues.apache.org/jira/browse/YARN-8468
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
> Affects Versions: 3.1.0
> Reporter: Antal Bálint Steinbach
> Assignee: Antal Bálint Steinbach
> Priority: Critical
> Attachments: YARN-8468.000.patch, YARN-8468.001.patch,
> YARN-8468.002.patch, YARN-8468.003.patch, YARN-8468.004.patch,
> YARN-8468.005.patch, YARN-8468.006.patch, YARN-8468.007.patch,
> YARN-8468.008.patch, YARN-8468.009.patch, YARN-8468.010.patch,
> YARN-8468.011.patch, YARN-8468.012.patch
>
>
> When using any scheduler, you can use "yarn.scheduler.maximum-allocation-mb"
> to limit the overall size of a container. This applies globally to all
> containers and cannot be limited by queue or and is not scheduler dependent.
>
> The goal of this ticket is to allow this value to be set on a per queue basis.
>
> The use case: User has two pools, one for ad hoc jobs and one for enterprise
> apps. User wants to limit ad hoc jobs to small containers but allow
> enterprise apps to request as many resources as needed. Setting
> yarn.scheduler.maximum-allocation-mb sets a default value for maximum
> container size for all queues and setting maximum resources per queue with
> “maxContainerResources” queue config value.
>
> Suggested solution:
>
> All the infrastructure is already in the code. We need to do the following:
> * add the setting to the queue properties for all queue types (parent and
> leaf), this will cover dynamically created queues.
> * if we set it on the root we override the scheduler setting and we should
> not allow that.
> * make sure that queue resource cap can not be larger than scheduler max
> resource cap in the config.
> * implement getMaximumResourceCapability(String queueName) in the
> FairScheduler
> * implement getMaximumResourceCapability() in both FSParentQueue and
> FSLeafQueue as follows
> * expose the setting in the queue information in the RM web UI.
> * expose the setting in the metrics etc for the queue.
> * write JUnit tests.
> * update the scheduler documentation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
