[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619569#comment-16619569
]
Zian Chen commented on YARN-8777:
---------------------------------
Hi [~eyang], thanks for the patch, some quick suggestions and questions,
1.
{code:java}
/**
+ * Get the Docker exec command line string. The function will verify that the
params file is meant for the exec command.
+ * @param command_file File containing the params for the Docker start command
+ * @param conf Configuration struct containing the container-executor.cfg
details
+ * @param out Buffer to fill with the exec command
+ * @param outlen Size of the output buffer
+ * @return Return code with 0 indicating success and non-zero codes indicating
error
+ */
+int get_docker_exec_command(const char* command_file, const struct
configuration* conf, args *args);{code}
The method param list have out an outlen which didn't match the signature, and
we miss description for param args, is this typo?
2. for the code reuse you discussed with [~ebadger], my quick thoughts is
instead of passing parameters from node manager, we can probably give an enum
to index several common used command options, and ask node manager only pass
index which can be matched with one of these enum elements, in this way we can
have some kind of flexibility without open up bigger attack interface.
3. This patch seems focus on running docker exec -it command to attach to a
running container, but later on when the pipeline is been build, should we also
take care of passing shell commands inside the container ?
> Container Executor C binary change to execute interactive docker command
> ------------------------------------------------------------------------
>
> Key: YARN-8777
> URL: https://issues.apache.org/jira/browse/YARN-8777
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Zian Chen
> Assignee: Eric Yang
> Priority: Major
> Labels: Docker
> Attachments: YARN-8777.001.patch
>
>
> Since Container Executor provides Container execution using the native
> container-executor binary, we also need to make changes to accept new
> “dockerExec” method to invoke the corresponding native function to execute
> docker exec command to the running container.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
