[ https://issues.apache.org/jira/browse/YARN-7599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619631#comment-16619631 ]
Botong Huang commented on YARN-7599: ------------------------------------ Thanks [~bibinchundatt] for the review! [^YARN-7599-YARN-7402.v5.patch] uploaded with fixes. bq. 4. Rename testcase name -> testBasicCase This is already the test case name, typo? bq. 1. During long maintainance period of cluster, We might require option to disable cleaner at run time. rt ?? Application cleaner is disabled when YarnConfiguration.GPG_APPCLEANER_INTERVAL_MS is set to zero or negative value: {code:java} 120 long appCleanerIntervalMs = 121 getConfig().getLong(YarnConfiguration.GPG_APPCLEANER_INTERVAL_MS, 122 YarnConfiguration.DEFAULT_GPG_APPCLEANER_INTERVAL_MS); 123 if (appCleanerIntervalMs > 0) { 124 this.scheduledExecutorService.scheduleAtFixedRate(this.applicationCleaner, 125 0, appCleanerIntervalMs, TimeUnit.MILLISECONDS); {code} > [GPG] ApplicationCleaner in Global Policy Generator > --------------------------------------------------- > > Key: YARN-7599 > URL: https://issues.apache.org/jira/browse/YARN-7599 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Botong Huang > Assignee: Botong Huang > Priority: Minor > Labels: federation, gpg > Attachments: YARN-7599-YARN-7402.v1.patch, > YARN-7599-YARN-7402.v2.patch, YARN-7599-YARN-7402.v3.patch, > YARN-7599-YARN-7402.v4.patch, YARN-7599-YARN-7402.v5.patch > > > In Federation, we need a cleanup service for StateStore as well as Yarn > Registry. For the former, we need to remove old application records. For the > latter, failed and killed applications might leave records in the Yarn > Registry (see YARN-6128). We plan to do both cleanup work in > ApplicationCleaner in GPG -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org