[
https://issues.apache.org/jira/browse/YARN-7599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16620437#comment-16620437
]
Bibin A Chundatt edited comment on YARN-7599 at 9/19/18 3:26 PM:
-----------------------------------------------------------------
Thanks [~botong] for updated patch
{quote}Application cleaner is disabled when
YarnConfiguration.GPG_APPCLEANER_INTERVAL_MS is set to zero or negative value:
{quote} # I was thinking of disabling cleaner while the GPG service is live.
Shell command to reset clean interval. Similar to
{{HSAdminServer#refreshLogRetentionSettings}}. As future work
# Related to testcase name,IMHO better rename to
testFederationStoreAppsCleanUp.
# Can you change to single configuration similar to
dfs.http.client.retry.policy.spec \{min,max,interval}. Any comments on this
point?
{code:java}
60 if (LOG.isDebugEnabled()) {
61 LOG.debug("List of apps: ",
routerApps.stream().map(Object::toString)
62 .collect(Collectors.joining(",")));
63 }
{code}
# Regarding logs, i think better to print candidates for delete . Instead of
all apps
# Please handle applicable check style issues too. Not able to open CI results
now.
was (Author: bibinchundatt):
Thanks [~botong] for updated patch
{quote}
Application cleaner is disabled when
YarnConfiguration.GPG_APPCLEANER_INTERVAL_MS is set to zero or negative value:
{quote}
# I was thinking of disabling cleaner while the GPG service is live. Shell
command to reset clean interval. Similar to
{{HSAdminServer#refreshLogRetentionSettings}}. As future work
# Related to testcase name,IMHO better rename to testFederationStoreAppsCleanUp.
# Can you change to single configuration similar to
dfs.http.client.retry.policy.spec {min,max,interval}. Any comments on this
point?
{code}
60 if (LOG.isDebugEnabled()) {
61 LOG.debug("List of apps: ",
routerApps.stream().map(Object::toString)
62 .collect(Collectors.joining(",")));
63 }
{code}
# Regarding logs, i think better to print candidates for delete . Instead of
all apps
# Handle checkstyle issues .I am not able to CI results now.
> [GPG] ApplicationCleaner in Global Policy Generator
> ---------------------------------------------------
>
> Key: YARN-7599
> URL: https://issues.apache.org/jira/browse/YARN-7599
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Botong Huang
> Assignee: Botong Huang
> Priority: Minor
> Labels: federation, gpg
> Attachments: YARN-7599-YARN-7402.v1.patch,
> YARN-7599-YARN-7402.v2.patch, YARN-7599-YARN-7402.v3.patch,
> YARN-7599-YARN-7402.v4.patch, YARN-7599-YARN-7402.v5.patch
>
>
> In Federation, we need a cleanup service for StateStore as well as Yarn
> Registry. For the former, we need to remove old application records. For the
> latter, failed and killed applications might leave records in the Yarn
> Registry (see YARN-6128). We plan to do both cleanup work in
> ApplicationCleaner in GPG
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
