[ 
https://issues.apache.org/jira/browse/YARN-8734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624780#comment-16624780
 ] 

Billie Rinaldi commented on YARN-8734:
--------------------------------------

I am fine with calling the field "dependencies" instead of 
"remote_service_dependencies."

bq. all properties including dependencies should be under the properties section
This isn't the case. Dependencies is a field of Component, so it makes sense as 
a field of Service as well.

Overall this patch looks good. I have one question regarding the RM AM liveness 
monitor. It seems like the AM might get expired by the RM after the 
yarn.am.liveness-monitor.expiry-interval-ms (default 10 minutes) while the AM 
is waiting for service dependencies, since the dependency check is performed 
before the AM has registered with the RM. It looks like AMRMClientAsyncImpl 
starts up a heartbeat thread when registerApplicationMaster is called. Let's 
discuss whether it makes sense to perform the dependency check before or after 
the AM registers with the RM.

> Readiness check for remote service
> ----------------------------------
>
>                 Key: YARN-8734
>                 URL: https://issues.apache.org/jira/browse/YARN-8734
>             Project: Hadoop YARN
>          Issue Type: New Feature
>          Components: yarn-native-services
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>            Priority: Major
>         Attachments: Dependency check vs.pdf, YARN-8734.001.patch, 
> YARN-8734.002.patch, YARN-8734.003.patch, YARN-8734.004.patch, 
> YARN-8734.005.patch
>
>
> When a service is deploying, there can be remote service dependency.  It 
> would be nice to describe ZooKeeper as a dependent service, and the service 
> has reached a stable state, then deploy HBase.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to