[
https://issues.apache.org/jira/browse/YARN-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636511#comment-16636511
]
Abhishek Modi commented on YARN-8834:
-------------------------------------
[~rohithsharma] thanks for reviewing it. I will attach a patch with the fix.
{quote}I am thinking should reader client more abstract to entities only? I
mean just to have getEntity() and getEntities() with much more options to
provide query params. Thoughts?
{quote}
Instead of exposing generic API like this, should I make existing APIs generic
enough to take params and filters as parameters. I am not in favor of taking
url path as input parameter as that can be abused and client need to know about
all the endpoints. In future, we can add more apis as and when required.
> Provide Java client for fetching entities from TimelineReader
> -------------------------------------------------------------
>
> Key: YARN-8834
> URL: https://issues.apache.org/jira/browse/YARN-8834
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelinereader
> Reporter: Rohith Sharma K S
> Assignee: Abhishek Modi
> Priority: Critical
> Attachments: YARN-8834.001.patch, YARN-8834.002.patch
>
>
> While reviewing YARN-8303, we felt that it is necessary to provide
> TimelineReaderClient which wraps all the REST calls in it so that user can
> just provide EntityType and EntityId along with filters.Currently fetching
> entities from TimelineReader is only via REST call or somebody need to write
> java client get entities.
> It is good to provide TimelineReaderClient which fetch entities from
> TimelineReaderServer. This will be more useful.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
