[
https://issues.apache.org/jira/browse/YARN-7225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640127#comment-16640127
]
Jonathan Hung edited comment on YARN-7225 at 10/5/18 5:44 PM:
--------------------------------------------------------------
Thanks [~eepayne], one small comment, it seems in
FiCaSchedulerApp/FSAppAttempt/FifoAppAttempt there's some checks that look
like: {{!appAMNodePartitionName.equals(""))}} / {{partition.equals(""))}} (two
in FiCaSchedulerApp, two in FSAppAttempt, one in FifoAppAttempt), I think we
can remove these right? Since this will be checked by the isEmpty() checks
preceding it.
Other than that, LGTM
was (Author: jhung):
Thanks [~eepayne], one small comment, it seems in
FiCaSchedulerApp/FSAppAttempt/FifoAppAttempt there's some checks that look
like: {{!appAMNodePartitionName.equals("")) }} / {{partition.equals("")) }}
(two in FiCaSchedulerApp, two in FSAppAttempt, one in FifoAppAttempt), I think
we can remove these right? Since this will be checked by the isEmpty() checks
preceding it.
Other than that, LGTM
> Add queue and partition info to RM audit log
> --------------------------------------------
>
> Key: YARN-7225
> URL: https://issues.apache.org/jira/browse/YARN-7225
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
> Reporter: Jonathan Hung
> Assignee: Eric Payne
> Priority: Major
> Attachments: YARN-7225.001.patch, YARN-7225.002.patch
>
>
> Right now RM audit log has fields such as user, ip, resource, etc. Having
> queue and partition is useful for resource tracking.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
