[ 
https://issues.apache.org/jira/browse/YARN-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659620#comment-16659620
 ] 

Íñigo Goiri commented on YARN-8928:
-----------------------------------

Thanks [~belugabehr] for  [^YARN-8928.2.patch].
A couple comments:
* I would move the comment about the tests depending on the order to the new 
function.
* I think {{buildAclString()}} could add the strings to a TreeSet and then we 
can use the join of collections there. This reflects exactly the way this is 
generated.
* We may want to add a pointer to the AccessControlList in the javadoc 
mentioning this is the source of such order.


> TestRMAdminService is failing
> -----------------------------
>
>                 Key: YARN-8928
>                 URL: https://issues.apache.org/jira/browse/YARN-8928
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 3.3.0
>            Reporter: Jason Lowe
>            Assignee: BELUGA BEHR
>            Priority: Major
>         Attachments: YARN-8928.1.patch, YARN-8928.2.patch
>
>
> After HADOOP-15836 TestRMAdminService has started failing consistently.  
> Sample stacktraces to follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to