[
https://issues.apache.org/jira/browse/YARN-8851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659747#comment-16659747
]
Wangda Tan commented on YARN-8851:
----------------------------------
[~tangzhankun],
Thanks for updating the patch, the latest patch looks much better now.
One suggestion:
* The DevicePluginAdapter extends/implements 4 interfaces, Instead of doing
that, is it possible to just make the Adapter implements ResourcePlugin
interface, and make several "sub-adapter" to implement ResourceHandler,
DockerCommandPlugin, and NMResourceUpdaterPlugin? By doing this, we can get a
more grandularized interface definition and very much close to ResourcePlugin
interface so less changes of integration code required.
* I can understand most of the DevicePluginAdapter logics should be alike
GPUResourcePlugin implementation, but some part will come from
DeviceRuntimeSpec. It gonna be help to get more concrete implementation to see
if our APIs properly designed or not.
And I haven't dig into details of code logics / naming, etc. while we're trying
to sort out overall code structure.
> [Umbrella] A new pluggable device plugin framework to ease vendor plugin
> development
> ------------------------------------------------------------------------------------
>
> Key: YARN-8851
> URL: https://issues.apache.org/jira/browse/YARN-8851
> Project: Hadoop YARN
> Issue Type: New Feature
> Components: yarn
> Reporter: Zhankun Tang
> Assignee: Zhankun Tang
> Priority: Major
> Attachments: YARN-8851-WIP2-trunk.001.patch,
> YARN-8851-WIP3-trunk.001.patch, YARN-8851-WIP4-trunk.001.patch,
> YARN-8851-WIP5-trunk.001.patch, YARN-8851-WIP6-trunk.001.patch, [YARN-8851]
> YARN_New_Device_Plugin_Framework_Design_Proposal-3.pdf, [YARN-8851]
> YARN_New_Device_Plugin_Framework_Design_Proposal.pdf
>
>
> At present, we support GPU/FPGA device in YARN through a native, coupling
> way. But it's difficult for a vendor to implement such a device plugin
> because the developer needs much knowledge of YARN internals. And this brings
> burden to the community to maintain both YARN core and vendor-specific code.
> Here we propose a new device plugin framework to ease vendor device plugin
> development and provide a more flexible way to integrate with YARN NM.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
