[ https://issues.apache.org/jira/browse/YARN-8982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677557#comment-16677557 ]
Íñigo Goiri commented on YARN-8982: ----------------------------------- Thanks [~giovanni.fumarola] for the patch. A few comments: * You can solve the checkstyle issues. * The random generator pattern should follow the typical unit test approach for these. * {{TestWeightedRandomRouterPolicy}} line 93 you can avoid. * Can you update the documentation with this new policy? * The javadoc in {{LocalityRouterPolicy}} should use the HTML-like format. * Can you use logger style logs? In the past we had a similar policy to submit always to the local subcluster (YARN-8626); can we link them? > [Router] Add locality policy > ----------------------------- > > Key: YARN-8982 > URL: https://issues.apache.org/jira/browse/YARN-8982 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Giovanni Matteo Fumarola > Assignee: Giovanni Matteo Fumarola > Priority: Major > Attachments: YARN-8982.v1.patch > > > This jira tracks the effort to add a new policy in the Router. > This policy will allow the Router to pick the SubCluster based on the node > that the client requested. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org