[ https://issues.apache.org/jira/browse/YARN-8672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678585#comment-16678585 ]
Chandni Singh commented on YARN-8672: ------------------------------------- [~eyang] yes I looked into having the token filename as an optional argument. The problem with that is right now the last argument to {{ContainerLocalizer}} is a list of local dirs. Local dirs are from {{argv[5]...argv.length}}. This is why we cannot make token file an optional argument because the optional argument has to go to the end but then the program will not know if it is a local dir or token file. If we have to make it optional, we have to either do a hack, for eg. if the last argument is "tokenFileName=filename" then it is a token file otherwise it is a local dir. Or we change the way arguments are parsed by {{ContainerLocalizer}}, that is, have flags so that order of arguments don't matter. This will be backward incompatible. I think, for now, making the argument mandatory will be better. > TestContainerManager#testLocalingResourceWhileContainerRunning occasionally > times out > ------------------------------------------------------------------------------------- > > Key: YARN-8672 > URL: https://issues.apache.org/jira/browse/YARN-8672 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager > Affects Versions: 3.2.0 > Reporter: Jason Lowe > Assignee: Chandni Singh > Priority: Major > Attachments: YARN-8672.001.patch, YARN-8672.002.patch, > YARN-8672.003.patch, YARN-8672.004.patch, YARN-8672.005.patch > > > Precommit builds have been failing in > TestContainerManager#testLocalingResourceWhileContainerRunning. I have been > able to reproduce the problem without any patch applied if I run the test > enough times. It looks like something is removing container tokens from the > nmPrivate area just as a new localizer starts. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org