[
https://issues.apache.org/jira/browse/YARN-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13785407#comment-13785407
]
Andrey Klochkov commented on YARN-677:
--------------------------------------
I looked at the difference in coverage before and after the patch. There are 2
test methods added:
1. "testSchedulerHandleFailWithExternalEvents" checks that
FairScheduler.handle() throws RuntimeException when supplied with a wrong event
type. Actual check is missing so seems like the test will pass in any case.
This is a very minor addition to the coverage. If we want to keep it, I can add
the check and update the patch.
2. "testAggregateCapacityTrackingWithPreemptionEnabled" -- not sure about the
intention. I see that it adds coverage to the
FairScheduler.preemptTasksIfNecessary() method, but basically it just sleeps so
the method is invoked, but preemption never happens and the test is not making
any checks. I think we can skip this one.
Should we keep #1?
> Increase coverage to FairScheduler
> ----------------------------------
>
> Key: YARN-677
> URL: https://issues.apache.org/jira/browse/YARN-677
> Project: Hadoop YARN
> Issue Type: Test
> Affects Versions: 3.0.0, 2.0.3-alpha, 0.23.6
> Reporter: Vadim Bondarev
> Assignee: Andrey Klochkov
> Attachments: HADOOP-4536-branch-2-a.patch,
> HADOOP-4536-branch-2c.patch, HADOOP-4536-trunk-a.patch,
> HADOOP-4536-trunk-c.patch, HDFS-4536-branch-2--N7.patch,
> HDFS-4536-branch-2--N8.patch, HDFS-4536-branch-2-N9.patch,
> HDFS-4536-trunk--N6.patch, HDFS-4536-trunk--N7.patch,
> HDFS-4536-trunk--N8.patch, HDFS-4536-trunk-N9.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
