[
https://issues.apache.org/jira/browse/YARN-8997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684476#comment-16684476
]
Hudson commented on YARN-8997:
------------------------------
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15411 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/15411/])
YARN-8997. [Submarine] Small refactors of modifier, condition check and
(gifuma: rev e269c3fb5a938e4359232628175569dbbd1a12c1)
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-submarine/src/main/java/org/apache/hadoop/yarn/submarine/runtimes/yarnservice/YarnServiceJobMonitor.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-submarine/src/main/java/org/apache/hadoop/yarn/submarine/runtimes/yarnservice/YarnServiceUtils.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-submarine/src/main/java/org/apache/hadoop/yarn/submarine/client/cli/CliUtils.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-submarine/src/main/java/org/apache/hadoop/yarn/submarine/runtimes/yarnservice/YarnServiceJobSubmitter.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-submarine/src/main/java/org/apache/hadoop/yarn/submarine/runtimes/common/FSBasedSubmarineStorageImpl.java
> [Submarine] Small refactors of modifier, condition check and redundant local
> variables
> ---------------------------------------------------------------------------------------
>
> Key: YARN-8997
> URL: https://issues.apache.org/jira/browse/YARN-8997
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Zhankun Tang
> Assignee: Zhankun Tang
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: YARN-8997-trunk-001.patch, YARN-8997-trunk-002.patch
>
>
> In YarnServiceJobSubmitter#needHdfs. Below code can be simplified to just one
> line.
> {code:java}
> if (content != null && content.contains("hdfs://")) {
> return true;
> }
> return false;{code}
> {code:java}
> return content != null && content.contains("hdfs://");{code}
> In CliUtils#argsForHelp
> {code:java}
> if (args[0].equals("-h") || args[0].equals("--help")) {
> return true;
> }
> {code}
> Can be simlified to:
> {code:java}
> return args[0].equals("-h") || args[0].equals("--help");{code}
> And several redundant variables can be removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
