[ 
https://issues.apache.org/jira/browse/YARN-8925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692794#comment-16692794
 ] 

Tao Yang edited comment on YARN-8925 at 11/20/18 7:45 AM:
----------------------------------------------------------

Hi, [~cheersyang]

Can we change the log level of updating node attributes in 
NodeAttributesManagerImpl#internalUpdateAttributesOnNodes from DEBUG to INFO? 
After this patch, This log won't print too much. I think it's necessary to 
record the updated node attributes. What do you think about this? Thanks.


was (Author: tao yang):
Hi, [~cheersyang]

Can we change the log level of updating node attributes in 
NodeAttributesManagerImpl#internalUpdateAttributesOnNodes from DEBUG to INFO? 
After this patch, This log won't print very much. I think it's necessary to 
record the updated node attributes. What do you think about this? Thanks.

> Updating distributed node attributes only when necessary
> --------------------------------------------------------
>
>                 Key: YARN-8925
>                 URL: https://issues.apache.org/jira/browse/YARN-8925
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: 3.2.1
>            Reporter: Tao Yang
>            Assignee: Tao Yang
>            Priority: Major
>              Labels: performance
>         Attachments: YARN-8925.001.patch, YARN-8925.002.patch, 
> YARN-8925.003.patch, YARN-8925.004.patch, YARN-8925.005.patch, 
> YARN-8925.006.patch, YARN-8925.007.patch, YARN-8925.008.patch
>
>
> Currently if distributed node attributes exist, even though there is no 
> change, updating for distributed node attributes will happen in every 
> heartbeat between NM and RM. Updating process will hold 
> NodeAttributesManagerImpl#writeLock and may have some influence in a large 
> cluster. We have found nodes UI of a large cluster is opened slowly and most 
> time it's waiting for the lock in NodeAttributesManagerImpl. I think this 
> updating should be called only when necessary to enhance the performance of 
> related process.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to