[ 
https://issues.apache.org/jira/browse/YARN-8948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16695727#comment-16695727
 ] 

Wilfred Spiegelenburg commented on YARN-8948:
---------------------------------------------

Thank you [~bibinchundatt] for the updated patch:
We should remove the unused import in {{PlacementRule.java}} but beside that 
the patch looks good, nice and simple.
test4tests -1 is OK, no new tests are needed.
The junit test failure is a known ZK issue and already tracked

> PlacementRule interface should be for all YarnSchedulers
> --------------------------------------------------------
>
>                 Key: YARN-8948
>                 URL: https://issues.apache.org/jira/browse/YARN-8948
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>            Priority: Major
>         Attachments: YARN-8948.001.patch, YARN-8948.002.patch, 
> YARN-8948.003.patch, YARN-8948.004.patch
>
>
> *Issue 1:*
> YARN-3635 intention was to add PlacementRule interface common for all 
> YarnSchedules.
> {code}
> 33      public abstract boolean initialize(
> 34          CapacitySchedulerContext schedulerContext) throws IOException;
> {code}
> PlacementRule initialization is done using CapacitySchedulerContext binding 
> to CapacityScheduler



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to