[ https://issues.apache.org/jira/browse/YARN-9087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713313#comment-16713313 ]
Szilard Nemeth commented on YARN-9087: -------------------------------------- Thanks [~haibochen] for your review comments! # It was accidentally removed so I added it back in. # Good idea, fixed that # Fair enough, I checked all the fields for mutabilty and only included the ones in the toString() that are immutable. Also removed some fields that don't hold a value if printed (i.e. toString is not overridden). For the immutable fields, I also added the final modifier. > Better logging for initialization of Resource plugins > ----------------------------------------------------- > > Key: YARN-9087 > URL: https://issues.apache.org/jira/browse/YARN-9087 > Project: Hadoop YARN > Issue Type: Improvement > Components: yarn > Reporter: Szilard Nemeth > Assignee: Szilard Nemeth > Priority: Major > Attachments: YARN-9087.001.patch, YARN-9087.002.patch > > > The patch includes the following enahncements for logging: > - Logging initializer code of resource handlers in > {{LinuxContainerExecutor#init}} > - Logging initializer code of resource plugins in > {{ResourcePluginManager#initialize}} > - Added toString to {{ResourceHandlerChain}} > - Added toString to all implementations to subclasses of {{ResourcePlugin}} > as they are printed in {{ResourcePluginManager#initialize}} > - Added toString to all implementations to subclasses of {{ResourceHandler}} > as they are printed as a field of the {{LinuxContainerExecutor#init}} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org