[
https://issues.apache.org/jira/browse/YARN-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714776#comment-16714776
]
Peter Bacsko commented on YARN-9008:
------------------------------------
{quote}We are missing one unit test for upload a non-existent file and one for
a directory{quote}
Added test.
{quote}The new commandline option 'appname' should probably be renamed to
'app_name' for the sake of consistency with other options{quote}
I took that from {{Client.java}}, where it's also called {{appname}}. Shall I
re-name it anyway?
{quote}All IOExceptions are wrapped in a RunTimeException. But I am not sure
why benefits it provides than just directly throwing IOException{quote}
Unfortunately that piece of code is located in a {{forEach}} lambda and a
{{run()}} method which cannot be declared to throw {{IOException}}. So that's
why I had to wrap it.
{quote}Can we centralize them in one place?{quote}
I added a public static method to {{ApplicationMaster}}.
{quote}What do you think of renaming it to 'lib'?{quote}
I think "--lib" would imply that we deal with jar files. Since it's a somewhat
generic YARN application, I think it's OK to keep this switch.
> Extend YARN distributed shell with file localization feature
> ------------------------------------------------------------
>
> Key: YARN-9008
> URL: https://issues.apache.org/jira/browse/YARN-9008
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: yarn
> Affects Versions: 3.1.1
> Reporter: Peter Bacsko
> Assignee: Peter Bacsko
> Priority: Major
> Attachments: YARN-9008-001.patch, YARN-9008-002.patch,
> YARN-9008-003.patch, YARN-9008-004.patch
>
>
> YARN distributed shell is a very handy tool to test various features of YARN.
> However, it lacks support for file localization - that is, you define files
> in the command line that you wish to be localized remotely. This can be
> extremely useful in certain scenarios.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
