[ https://issues.apache.org/jira/browse/YARN-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723061#comment-16723061 ]
Peter Bacsko commented on YARN-9118: ------------------------------------ Some minor comments: * Please complete the javadoc for {{parseGpuDevicesFromUserDefinedValues()}} * I'm sure I'm missing something, but what's the benefit of storing stuff in {{Set<GpuDevice>}} then convert it to a List? Is it because of the boolean return value of {{Set.add()}} ? I think a simple {{contains()}} check would be sufficient here. * Nit: for consistency reasons, we could static import asserts here too > Handle issues with parsing user defined GPU devives in GpuDiscoverer > -------------------------------------------------------------------- > > Key: YARN-9118 > URL: https://issues.apache.org/jira/browse/YARN-9118 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Szilard Nemeth > Assignee: Szilard Nemeth > Priority: Major > Attachments: YARN-9118.001.patch, YARN-9118.002.patch, > YARN-9118.003.patch > > > getGpusUsableByYarn has the following issues: > - Duplicate GPU device definitions are not denied: This seems to be the > biggest issue as it could increase the number of devices on the node if the > device ID is defined 2 or more times. > - An empty-string is accepted, it works like the user would not want to use > auto-discovery and haven't defined any GPU devices: This will result in an > empty device list, but the empty-string check is never explicitly there in > the code, so this behavior just coincidental. > - Number validation does not happen on GPU device IDs (separated by commas) > Many testcases are added as the coverage was already very low. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org