[ 
https://issues.apache.org/jira/browse/YARN-9038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726610#comment-16726610
 ] 

Sunil Govindan commented on YARN-9038:
--------------------------------------

Thanks [~cheersyang]. Some more comments
 # In CsiAdaptorProtocolService ctor, {{csiDriverName}} value could be const 
string than a simple plain string.
 # In CsiAdaptorProtocolService#nodePublishVolume, some logs could be debug 
such as translated message ones.
 # In CsiClientImpl, could CsiGrpcClient be cached?
 # In NodePublishVolumeRequestProtoTranslator, cap and cap1 names could be more 
clearer.
 # recordContainerCsiVolumesRootDir, i saw a todo. Is that persistence needed? 
Will RM have a cache of allocated and mapped volumes?

 

> [CSI] Add ability to publish/unpublish volumes on node managers
> ---------------------------------------------------------------
>
>                 Key: YARN-9038
>                 URL: https://issues.apache.org/jira/browse/YARN-9038
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>            Priority: Major
>              Labels: CSI
>         Attachments: YARN-9038.001.patch, YARN-9038.002.patch, 
> YARN-9038.003.patch, YARN-9038.004.patch, YARN-9038.005.patch, 
> YARN-9038.006.patch
>
>
> We need to add ability to publish volumes on node managers in staging area, 
> under NM's local dir. And then mount the path to docker container to make it 
> visible in the container.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to