[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733723#comment-16733723
]
Wilfred Spiegelenburg commented on YARN-8967:
---------------------------------------------
Thank you [~leftnoteasy] It has been a long time since YARN-3635 was added. I
looked at moving over a long time ago but saw the impact and pushed it out.
I have extended the {{PlacementRule}} with new methods since the FS uses rules
slightly different than the CS. For instance there was no way to cater for
nesting of rules in the current setup. In other words I needed a standard way
to configure and store the rule that needs to be executed to generate the
parent queue name. The FS rules also have a configuration flag included which
specifies if the rule can return a dynamic queue or not. The scheduler always
has the ability to create a dynamic queue at any point in the hierarchy (below
a static or dynamic queue) but the rule contains the switch to allow this or
not.
Neither of these options were available in the {{PlacementRule}} and without
those there is no way to move the FS rules over.
The {{isTerminal}} method I tried to keep within the FairScheduler code but
with the nested rules the fact that the create flag is not always leading I
left it in the rule for now. Let me try and move it into the FS policy code
where it belongs in the next version of the patch.
I will also look at the checkstyles and test failures and update/fix those.
> Change FairScheduler to use PlacementRule interface
> ---------------------------------------------------
>
> Key: YARN-8967
> URL: https://issues.apache.org/jira/browse/YARN-8967
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: capacityscheduler, fairscheduler
> Reporter: Wilfred Spiegelenburg
> Assignee: Wilfred Spiegelenburg
> Priority: Major
> Attachments: YARN-8967.001.patch, YARN-8967.002.patch,
> YARN-8967.003.patch
>
>
> The PlacementRule interface was introduced to be used by all schedulers as
> per YARN-3635. The CapacityScheduler is using it but the FairScheduler is not
> and is using its own rule definition.
> YARN-8948 cleans up the implementation and removes the CS references which
> should allow this change to go through.
> This would be the first step in using one placement rule engine for both
> schedulers.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
