[
https://issues.apache.org/jira/browse/YARN-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736490#comment-16736490
]
Wilfred Spiegelenburg commented on YARN-9173:
---------------------------------------------
[~cheersyang] I have added a patch for branch 3.1 this same patch will also
apply to branch 3.0.
[~yoelee]: We cannot use this patch for any 2.x release as the {{addExact}}
method used is a java 1.8 method which we cannot use in branch-2. Just
replacing that one call in the {{safeAdd}} with an overflow safe addition
should allow you to backport to branch-2.
> FairShare calculation broken for large values after YARN-8833
> -------------------------------------------------------------
>
> Key: YARN-9173
> URL: https://issues.apache.org/jira/browse/YARN-9173
> Project: Hadoop YARN
> Issue Type: Bug
> Components: fairscheduler
> Affects Versions: 3.3.0
> Reporter: Wilfred Spiegelenburg
> Assignee: Wilfred Spiegelenburg
> Priority: Major
> Fix For: 3.3.0, 3.2.1
>
> Attachments: YARN-9137-branch3.1.001.patch, YARN-9173.001.patch,
> YARN-9173.002.patch
>
>
> After the fix for the infinite loop in YARN-8833 we now get the wrong values
> back for fairshare calculations under certain circumstances. The current
> implementation works when the total resource is smaller than Integer.MAXVALUE.
> When the total resource goes above that value the number of iterations is not
> enough to converge to the correct value.
> The new test {{testResourceUsedWithWeightToResourceRatio()}} only checks that
> the calculation does not hang but does not check the outcome of the
> calculation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
