[ https://issues.apache.org/jira/browse/YARN-9148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16741324#comment-16741324 ]
Bibin A Chundatt commented on YARN-9148: ---------------------------------------- {quote}Will this dir ever have subdirectories? {quote} No sub directories in application directory. *Structure is as follows* * With out rolling aggregation application1/nodeid1 nodeid2 * Rolling aggregation enabled in NM application1/nodeid_timestamp1 /nodeid_timestamp2 > AggregatedLogDeletion doesnt work with S3 > ----------------------------------------- > > Key: YARN-9148 > URL: https://issues.apache.org/jira/browse/YARN-9148 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Bibin A Chundatt > Priority: Critical > Attachments: YARN-9148.001.patch > > > Aggregated Log deletion works based on modification time of application > directory > S3AFileStatus give current time in case of directory. > {code} > if (appDir.isDirectory() && > appDir.getModificationTime() < cutoffMillis) { > ApplicationId appId = ApplicationId.fromString( > {code} > S3AFileStatus#getModificationTime > {code} > @Override > public long getModificationTime(){ > if(isDirectory()){ > return System.currentTimeMillis(); > } else { > return super.getModificationTime(); > } > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org