[
https://issues.apache.org/jira/browse/YARN-6616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749051#comment-16749051
]
Eric Payne commented on YARN-6616:
----------------------------------
[~Prabhu Joseph], thank you for updating the new patch.
{quote}{quote}I also wonder how this fix getting in would not break
compatibility in a minor release
{quote}
... add a new interface and keep the existing (although broken) one.
{quote}
I have uploaded a suggestion for what I mean by keeping the old interfaces. I
think it is very important to allow existing downstream applications to
continue to work when Hadoop has a minor version upgrade.
My thoughts:
There are 3 signatures for {{AplicationReport#newinstance}}. The first has 20
parameters, the second has 24, and the third has 25. I did not update the
second interface. It seems very messy to me because the method is exactly the
same as the third one with the addition of one parameter. The second should at
least call the third, and it may be possible to remove the second one all
together.
In any event, I suggest that you make 2 additional APIs for the first and
third, with the old APIs calling the new ones, as indicated in my file. This
way, you protect downstream apps from breaking, and you also remove the
necessity of modifying all of those unit tests where you were just adding a
{{0}} as a dummy parameter.
> YARN AHS shows submitTime for jobs same as startTime
> ----------------------------------------------------
>
> Key: YARN-6616
> URL: https://issues.apache.org/jira/browse/YARN-6616
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 2.7.3
> Reporter: Prabhu Joseph
> Assignee: Prabhu Joseph
> Priority: Minor
> Attachments: 0001-YARN-6616.patch, 0002-YARN-6616.patch,
> 0003-YARN-6616.patch, 0004-YARN-6616.patch, 0005-YARN-6616.patch,
> ApplicationReport.poc
>
>
> YARN AHS returns startTime value for both submitTime and startTime for the
> jobs. Looks the code sets the submitTime with startTime value.
> https://github.com/apache/hadoop/blob/branch-2.7.3/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/dao/AppInfo.java#L80
> {code}
> curl --negotiate -u:
> http://prabhuzeppelin3.openstacklocal:8188/ws/v1/applicationhistory/apps
> <submittedTime>1495015537574</submittedTime><startedTime>1495015537574</startedTime><finishedTime>1495016384084</finishedTime>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
