[ 
https://issues.apache.org/jira/browse/YARN-8901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16754276#comment-16754276
 ] 

Hadoop QA commented on YARN-8901:
---------------------------------

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 19m 
11s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
28s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
19s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
33s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
12m 32s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
45s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
20s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
13m  8s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
26s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 17m 
53s{color} | {color:green} hadoop-yarn-services-core in the patch passed. 
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
22s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 69m  9s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f |
| JIRA Issue | YARN-8901 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12956595/YARN-8901.3.patch |
| Optional Tests |  dupname  asflicense  compile  javac  javadoc  mvninstall  
mvnsite  unit  shadedclient  findbugs  checkstyle  |
| uname | Linux 65207c5297f9 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 8326450 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| findbugs | v3.1.0-RC1 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/23212/testReport/ |
| Max. process+thread count | 765 (vs. ulimit of 10000) |
| modules | C: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core
 U: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core
 |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/23212/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> Restart "NEVER" policy does not work with component dependency
> --------------------------------------------------------------
>
>                 Key: YARN-8901
>                 URL: https://issues.apache.org/jira/browse/YARN-8901
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 3.1.1
>            Reporter: Yesha Vora
>            Assignee: Suma Shivaprasad
>            Priority: Critical
>         Attachments: YARN-8901.1.patch, YARN-8901.2.patch, YARN-8901.3.patch
>
>
> Scenario:
> 1) Launch an application with two components. master and worker. Here, worker 
> is dependent on master. ( Worker should be launched only after master is 
> launched )
> 2) Set restart_policy = NEVER for both master and worker. 
> {code:title=sample launch.json}
> {
>       "name": "mawo-hadoop-ut",
>         "artifact": {
>                 "type": "DOCKER",
>                 "id": "xxx"
>         },
>         "configuration": {
>                 "env": {
>                        "YARN_CONTAINER_RUNTIME_DOCKER_CONTAINER_NETWORK": 
> "hadoop"
>                  },
>                 "properties": {
>                        "docker.network": "hadoop"
>                 }
>         },
>       "components": [{
>               "dependencies": [],
>               "resource": {
>                       "memory": "2048",
>                       "cpus": "1"
>               },
>               "name": "master",
>                 "run_privileged_container": true,
>               "number_of_containers": 1,
>               "launch_command": "start master",
>                 "restart_policy": "NEVER",
>       }, {
>               "dependencies": ["master"],
>               "resource": {
>                       "memory": "8072",
>                       "cpus": "1"
>               },
>               "name": "worker",
>                 "run_privileged_container": true,
>               "number_of_containers": 10,
>               "launch_command": "start worker",
>                 "restart_policy": "NEVER",
>       }],
>       "lifetime": -1,
>       "version": 1.0
> }{code}
> When restart policy is selected to NEVER, AM never launches Worker component. 
> It get stuck with below message. 
> {code}
> 2018-10-17 15:11:58,560 [Component  dispatcher] INFO  component.Component - 
> [COMPONENT master] Transitioned from FLEXING to STABLE on CHECK_STABLE event.
> 2018-10-17 15:11:58,560 [pool-7-thread-1] INFO  instance.ComponentInstance - 
> [COMPINSTANCE master-0 : container_e41_1539027682947_0020_01_000002] 
> Transitioned from STARTED to READY on BECOME_READY event
> 2018-10-17 15:11:58,560 [pool-7-thread-1] INFO  component.Component - 
> [COMPONENT worker]: Dependency master not satisfied, only 1 of 1 instances 
> are ready or the dependent component has not completed 
> 2018-10-17 15:12:28,556 [pool-7-thread-1] INFO  component.Component - 
> [COMPONENT worker]: Dependency master not satisfied, only 1 of 1 instances 
> are ready or the dependent component has not completed 
> 2018-10-17 15:12:58,556 [pool-7-thread-1] INFO  component.Component - 
> [COMPONENT worker]: Dependency master not satisfied, only 1 of 1 instances 
> are ready or the dependent component has not completed 
> 2018-10-17 15:13:28,556 [pool-7-thread-1] INFO  component.Component - 
> [COMPONENT worker]: Dependency master not satisfied, only 1 of 1 instances 
> are ready or the dependent component has not completed 
> 2018-10-17 15:13:58,556 [pool-7-thread-1] INFO  component.Component - 
> [COMPONENT worker]: Dependency master not satisfied, only 1 of 1 instances 
> are ready or the dependent component has not completed 
> 2018-10-17 15:14:28,556 [pool-7-thread-1] INFO  component.Component - 
> [COMPONENT worker]: Dependency master not satisfied, only 1 of 1 instances 
> are ready or the dependent component has not completed {code}
> 'NEVER' restart policy expects master component to be finished before 
> starting workers. Master component can not finish the job without workers. 
> Thus, it create a deadlock.
> The logic for 'NEVER' restart policy should be fixed to allow worker 
> components to be launched as soon as master component is in READY state. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to