[ 
https://issues.apache.org/jira/browse/YARN-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13791952#comment-13791952
 ] 

Sandy Ryza commented on YARN-1182:
----------------------------------

Nit:
{code}
+        conf.set(YarnConfiguration.RM_ADMIN_ADDRESS, hostname + ":0");
+        conf.set(YarnConfiguration.RM_SCHEDULER_ADDRESS, hostname + ":0");
+        conf.set(YarnConfiguration.RM_RESOURCE_TRACKER_ADDRESS, hostname + 
":0");
+        WebAppUtils.setRMWebAppHostnameAndPort(getConfig(), hostname, 0);
{code}
getConfig() should be replaced with conf on the last line, right?

Otherwise LGTM

> MiniYARNCluster creates and inits the RM/NM only on start()
> -----------------------------------------------------------
>
>                 Key: YARN-1182
>                 URL: https://issues.apache.org/jira/browse/YARN-1182
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.1.0-beta
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: yarn-1182-1.patch
>
>
> MiniYARNCluster creates and inits the RM/NM only on start(). It should create 
> and init() during init() itself.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to