[ 
https://issues.apache.org/jira/browse/YARN-9139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767257#comment-16767257
 ] 

Peter Bacsko commented on YARN-9139:
------------------------------------

[~snemeth]

1. Please fix the remaining checkstyle issues
2. Why is {{TestFpgaDiscoverer}} class is referenced in 
{{TestGpuResourceHandler.java}} ?
3. Repeated use of {{Configuration conf = createDefaultConfig();}} - extract 
{{conf}} to a class variable and initialize once


> Simplify initializer code of GpuDiscoverer
> ------------------------------------------
>
>                 Key: YARN-9139
>                 URL: https://issues.apache.org/jira/browse/YARN-9139
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Major
>         Attachments: YARN-9139.001.patch, YARN-9139.002.patch, 
> YARN-9139.003.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to