[ 
https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16774426#comment-16774426
 ] 

Adam Antal commented on YARN-9121:
----------------------------------

Hi Szilard,
As I see through this patch, this is a patch rather about removing the 
"singleton-like" {{GpuDiscoverer}} Could you explain why it is necessary? 
Maybe could you also update the description accordingly? Otherwise the 
transformations are straightforward and correct.

> Users of GpuDiscoverer.getInstance() are not possible to test as instance is 
> a static field
> -------------------------------------------------------------------------------------------
>
>                 Key: YARN-9121
>                 URL: https://issues.apache.org/jira/browse/YARN-9121
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Major
>         Attachments: YARN-9121.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to