[
https://issues.apache.org/jira/browse/YARN-8891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16774786#comment-16774786
]
Sunil Govindan commented on YARN-8891:
--------------------------------------
Thanks [~tangzhankun]. A very detailed doc, thank you very much for this.
Few minor comments
1.
{code:java}
21 At present, YARN supports GPU/FPGA device through a native, coupling
way.
22 But it's difficult for a vendor to implement such a device plugin
23 because the developer needs too much knowledge of YARN internals.
{code}
We could say something like "developer need to understand various integration
points with YARN and also a deeper understanding YARN internals related to
NodeManager."
2. I think before we start "For instance, at least 6 classes to be implemented
(If you wanna support", we can say have a heading or sub section which says
"pain points for device plugin integration" and we can bullet point each one.
3. "The pluggable device framework not only simplify the plugin development but
also the YARN configurations." ==> "This pluggable device framework not only
simplifies the plugin development but also the number of configurations in YARN
which are needed for plugin integration."
4. In Prerequisites, could we make those points as 1,2, 3 or bulleted.
5. "Enable The Framework" => Enable Device Plugin Framework
6. "Configure The Sample Nvidia GPU Plugin" => "Configure sample Nvidia GPU
Plugin"
7. "After restarting YARN, you should see the `nvidia.com/gpu` resource count
shown when accessing YARN UI2 or issuing command:" => "After restarting YARN,
you should see the `nvidia.com/gpu` resource count displayed while accessing
YARN UI2 Overview and NodeManages page or issuing command:"
8 ."Develop Your Own Plugin" Could we move this section to a new .md file and
link it from here. So we ll have more better modularity.
Thanks
> Documentation of the pluggable device framework
> -----------------------------------------------
>
> Key: YARN-8891
> URL: https://issues.apache.org/jira/browse/YARN-8891
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Zhankun Tang
> Assignee: Zhankun Tang
> Priority: Major
> Attachments: YARN-8891-trunk.001.patch, YARN-8891-trunk.002.patch,
> YARN-8891-trunk.003.patch, YARN-8891-trunk.004.patch,
> YARN-8891-trunk.005.patch, YARN-8891-trunk.006.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
