[ 
https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776105#comment-16776105
 ] 

Sunil Govindan commented on YARN-9318:
--------------------------------------

Thanks for the patch [~snemeth].

I would like to optimize this a bit more. Currently three methods have same 
code post this patch. multiplyTo, multiplyAndRoundDown and multiplyAndRoundUp. 
Could this snippet be made common and invoke here. Thanks.

> Resources#multiplyAndRoundUp does not consider Resource Types
> -------------------------------------------------------------
>
>                 Key: YARN-9318
>                 URL: https://issues.apache.org/jira/browse/YARN-9318
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Major
>         Attachments: YARN-9318.001.patch
>
>
> org.apache.hadoop.yarn.util.resource.Resources#multiplyAndRoundUp only deals 
> with memory and vcores while computing the rounded value. It should also 
> consider custom Resource Types as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to