[
https://issues.apache.org/jira/browse/YARN-9326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16780015#comment-16780015
]
Wilfred Spiegelenburg commented on YARN-9326:
---------------------------------------------
Thank you for the updated patch [~adam.antal]
Some further text comments:
* For minResources this text is no longer correct when you take into account
resource types: {{For the single-resource fairness policy, the vcores value is
ignored.}} It should mention that it only uses the memory setting, since we can
have more resource types than just 2.
* This is not correct {{**maxResources**: maximum resources a queue will
allocated.}} it should be something like _can be allocated_ not _will allocated_
* Same text here needs to be fixed: {{**maxChildResources**: maximum resources
an ad hoc child queue will allocated.}}
* For the maxChildResources this is not correct: {{It's default value is
**yarn.scheduler.maximum-allocation-mb**.}} as it ignores types and even the
vcores:
** It should mention the vcore equivalent for the yarn config.
** The scheduler max allocation which is again a resource object and thus can
set a limit on all resource types. (via the resource type config file)
* This sentence should not be in the maxChildresource: {{In the latter case the
units will be inferred from the default units configured for that resource.}}
* A child queue limit is enforced recursively and thus will not be assigned a
container if that assignment would put the child queue or its parent(s) over
the maximum resources.
* In the last changed sentence: _or maximum_ change to _or to the maximum_
> Fair Scheduler configuration defaults are not documented in case of min and
> maxResources
> ----------------------------------------------------------------------------------------
>
> Key: YARN-9326
> URL: https://issues.apache.org/jira/browse/YARN-9326
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: docs, documentation, fairscheduler, yarn
> Affects Versions: 3.2.0
> Reporter: Adam Antal
> Assignee: Adam Antal
> Priority: Major
> Attachments: YARN-9326.001.patch, YARN-9326.002.patch,
> YARN-9326.003.patch
>
>
> The FairScheduler's configuration has the following defaults (from the code:
> javadoc):
> {noformat}
> In new style resources, any resource that is not specified will be set to
> missing or 0%, as appropriate. Also, in the new style resources, units are
> not allowed. Units are assumed from the resource manager's settings for the
> resources when the value isn't a percentage. The missing parameter is only
> used in the case of new style resources without percentages. With new style
> resources with percentages, any missing resources will be assumed to be 100%
> because percentages are only used with maximum resource limits.
> {noformat}
> This is not documented in the hadoop yarn site FairScheduler.html. It is
> quite intuitive, but still need to be documented though.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
