[
https://issues.apache.org/jira/browse/YARN-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784950#comment-16784950
]
Eric Yang commented on YARN-8805:
---------------------------------
{quote}However, I'm wondering about potential launch commands that contain
commas in them. We will need to escape them before passing to the
comma-separated exec format.{quote}
The .cmd file format needs to change to json in order to fix the comma
separated exec format serialization problem. That issue is a bigger scope than
this one. Let's fix that in container phase 3 as a separate issue.
{quote}Also, could we add a more robust test in addition to the one that tests
the functionality of the utility function? Something similar to
TestAbstractLauncher#testDockerContainerMounts where we check the launch
command would be nice. That way we can confirm that the utility function is
getting called correctly.{quote}
Sure, I will added a new test in TestAbstractProviderService to cover
BuildContainerLaunchCommand. Thanks
> Automatically convert the launch command to the exec form when using
> entrypoint support
> ---------------------------------------------------------------------------------------
>
> Key: YARN-8805
> URL: https://issues.apache.org/jira/browse/YARN-8805
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Shane Kumpf
> Assignee: Eric Yang
> Priority: Major
> Labels: Docker
> Attachments: YARN-8805.001.patch, YARN-8805.004.patch,
> YARN-8805.005.patch
>
>
> When {{YARN_CONTAINER_RUNTIME_DOCKER_RUN_OVERRIDE_DISABLE}} is true, and a
> launch command is provided, it is expected that the launch command is
> provided by the user in exec form.
> For example:
> {code:java}
> "/usr/bin/sleep 6000"{code}
> must be changed to:
> {code}"/usr/bin/sleep,6000"{code}
> If this is not done, the container will never start and will be in a Created
> state. We should automatically do this conversion vs making the user
> understand this nuance of using the entrypoint support. Docs should be
> updated to reflect this change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
