[
https://issues.apache.org/jira/browse/YARN-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791052#comment-16791052
]
Eric Yang commented on YARN-9378:
---------------------------------
Code looks good with one suggestion:
{code}
String output = DockerCommandExecutor.executeDockerCommand(
pullCommand, Long.toHexString(System.currentTimeMillis()),
null, privOpExecutor, false, localizer.nmContext);
{code}
In this context, there is no container id, maybe we can fix
preparePrivilegedOperation to accept null instead of passing system time to
make this more readable.
> Create Image Localizer
> ----------------------
>
> Key: YARN-9378
> URL: https://issues.apache.org/jira/browse/YARN-9378
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Chandni Singh
> Assignee: Chandni Singh
> Priority: Major
> Attachments: YARN-9378.001.patch
>
>
> {{LinuxContainerExecutor}} is for container operations. DockerImagesCommand
> is independent of any container. The image localizer acts as a service that
> will localize docker images and maintain an image cache. Other components can
> use this to query about the images on the node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
