[
https://issues.apache.org/jira/browse/YARN-7129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797840#comment-16797840
]
Eric Yang commented on YARN-7129:
---------------------------------
[~jeagles] {quote}I may have missed it, but I don't feel this comment was
addressed. Are we still bundling multiple features into this jira? What I see
is that there is still a 1MB+ patch and looks like we are trying to commit to a
top level umbrella jira.{quote}
Most of the patch is in fonts directory and a class that generates random
English sound alike words. The actual code is small when those pieces are
removed.
The rest of the code basically setup maven project framework for each of the
necessary pieces to go into sub modules. Patch size is not a good metric to
review New Feature patches. There are many examples of New Feature issues with
big patch, e.g. YARN-913, YARN-2928, HADOOP-8562 and many others.
[~billie.rinaldi] has done the due-diligence in reviewing the patch with detail
step by step improvements and had committed when basic structure is working.
The people who are interested in the application catalog have already done the
reviews and acquired the knowledge of inner work of this patch. Breaking down
the patch further at this point in time, would not help the community other
than introducing additional logistic overhead to check for correctness that had
already been checked. People have already been involved and able to reproduce.
Clear javadoc and documentation are also included for a good starting
trajectory.
If you think otherwise, please list details of how you want the refactoring
done. I will comply and request your reviews.
> Application Catalog for YARN applications
> -----------------------------------------
>
> Key: YARN-7129
> URL: https://issues.apache.org/jira/browse/YARN-7129
> Project: Hadoop YARN
> Issue Type: New Feature
> Components: applications
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Major
> Fix For: 3.3.0
>
> Attachments: YARN Appstore.pdf, YARN-7129.001.patch,
> YARN-7129.002.patch, YARN-7129.003.patch, YARN-7129.004.patch,
> YARN-7129.005.patch, YARN-7129.006.patch, YARN-7129.007.patch,
> YARN-7129.008.patch, YARN-7129.009.patch, YARN-7129.010.patch,
> YARN-7129.011.patch, YARN-7129.012.patch, YARN-7129.013.patch,
> YARN-7129.014.patch, YARN-7129.015.patch, YARN-7129.016.patch,
> YARN-7129.017.patch, YARN-7129.018.patch, YARN-7129.019.patch,
> YARN-7129.020.patch, YARN-7129.021.patch, YARN-7129.022.patch,
> YARN-7129.023.patch, YARN-7129.024.patch, YARN-7129.025.patch,
> YARN-7129.026.patch, YARN-7129.027.patch, YARN-7129.028.patch,
> YARN-7129.029.patch, YARN-7129.030.patch, YARN-7129.031.patch
>
>
> YARN native services provides web services API to improve usability of
> application deployment on Hadoop using collection of docker images. It would
> be nice to have an application catalog system which provides an editorial and
> search interface for YARN applications. This improves usability of YARN for
> manage the life cycle of applications.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
