[ 
https://issues.apache.org/jira/browse/YARN-4901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802731#comment-16802731
 ] 

Peter Bacsko commented on YARN-4901:
------------------------------------

[~snemeth] [~templedf] could you look at this short patch?

I also added {{DefaultMetricsSystem.shutdown()}} because it unregisters an 
object on JMX. If we don't do this, we might get:

{noformat}
org.apache.hadoop.metrics2.MetricsException: 
org.apache.hadoop.metrics2.MetricsException: 
Hadoop:service=ResourceManager,name=RMNMInfo already exists!
        at 
org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.newObjectName(DefaultMetricsSystem.java:135)
        at 
org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.newMBeanName(DefaultMetricsSystem.java:110)
        at org.apache.hadoop.metrics2.util.MBeans.getMBeanName(MBeans.java:123)
        at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:64)
        at 
org.apache.hadoop.yarn.server.resourcemanager.RMNMInfo.<init>(RMNMInfo.java:59)
        at 
org.apache.hadoop.yarn.server.resourcemanager.ResourceManager$RMActiveServices.serviceInit(ResourceManager.java:749)
...
{noformat}

> MockRM should clear the QueueMetrics when it starts
> ---------------------------------------------------
>
>                 Key: YARN-4901
>                 URL: https://issues.apache.org/jira/browse/YARN-4901
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: scheduler
>            Reporter: Daniel Templeton
>            Assignee: Peter Bacsko
>            Priority: Major
>         Attachments: YARN-4901-001.patch
>
>
> The {{ResourceManager}} rightly assumes that when it starts, it's starting 
> from naught.  The {{MockRM}}, however, violates that assumption.  For 
> example, in {{TestNMReconnect}}, each test method creates a new {{MockRM}} 
> instance.  The {{QueueMetrics.queueMetrics}} field is static, which means 
> that when multiple {{MockRM}} instances are created, the {{QueueMetrics}} 
> bleed over.  Having the MockRM clear the {{QueueMetrics}} when it starts 
> should resolve the issue.  I haven't looked yet at scope to see how hard easy 
> that is to do.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to