[ 
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803882#comment-16803882
 ] 

Antal Bálint Steinbach commented on YARN-9235:
----------------------------------------------

Hi,

LOGGER is renamed to LOG.

I agree that testing general exceptions need to be checked, but testing its 
error message is not the way to do that for several reasons. (parameters in the 
text, i18n, etc..)

I do not want to change the exception itself, as this was a small refactor and 
NPE fix. So I think this small tradeoff is acceptable in the test.

[~sunilg], [~tangzhankun] can you please push?

 

> If linux container executor is not set for a GPU cluster 
> GpuResourceHandlerImpl is not initialized and NPE is thrown
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-9235
>                 URL: https://issues.apache.org/jira/browse/YARN-9235
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: yarn
>    Affects Versions: 3.0.0, 3.1.0
>            Reporter: Antal Bálint Steinbach
>            Assignee: Antal Bálint Steinbach
>            Priority: Major
>         Attachments: YARN-9235.001.patch, YARN-9235.002.patch, 
> YARN-9235.003.patch, YARN-9235.004.patch
>
>
> If GPU plugin is enabled for the NodeManager, it is possible to run jobs with 
> GPU.
> However, if LinuxContainerExecutor is not configured, an NPE is thrown when 
> calling 
> {code:java}
> GpuResourcePlugin.getNMResourceInfo{code}
> Also, there are no warns in the log if GPU is misconfigured like this. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to