[
https://issues.apache.org/jira/browse/YARN-9227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804284#comment-16804284
]
Szilard Nemeth commented on YARN-9227:
--------------------------------------
Hi [~Prabhu Joseph]!
Some comments:
In the method "testDistributedShellCleanup":
# Result boolean variable is not used, can be removed.
# There's a while loop in the end: How can you be sure that it won't run
infinitely?
# You don't need the continue statement at the end of the while-loop
# In the assertion, the condition is negated ( {{!fs1.exists(path)}}). Use
assertFalse instead, without negating the fs1.exists(path) call.
# In the assertion, I would replace "Fails" with "failed".
Thanks!
> DistributedShell RelativePath is not removed at end
> ---------------------------------------------------
>
> Key: YARN-9227
> URL: https://issues.apache.org/jira/browse/YARN-9227
> Project: Hadoop YARN
> Issue Type: Bug
> Components: distributed-shell
> Affects Versions: 3.1.0
> Reporter: Prabhu Joseph
> Assignee: Prabhu Joseph
> Priority: Minor
> Attachments: 0001-YARN-9227.patch, 0002-YARN-9227.patch,
> 0003-YARN-9227.patch
>
>
> DistributedShell Job does not remove the relative path which contains jars
> and localized files.
> {code}
> [ambari-qa@ash hadoop-yarn]$ hadoop fs -ls
> /user/ambari-qa/DistributedShell/application_1542665708563_0017
> Found 2 items
> -rw-r--r-- 3 ambari-qa hdfs 46636 2019-01-23 13:37
> /user/ambari-qa/DistributedShell/application_1542665708563_0017/AppMaster.jar
> -rwx--x--- 3 ambari-qa hdfs 4 2019-01-23 13:37
> /user/ambari-qa/DistributedShell/application_1542665708563_0017/shellCommands
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
