[ https://issues.apache.org/jira/browse/YARN-9281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807952#comment-16807952 ]
Eric Yang commented on YARN-9281: --------------------------------- {quote}I think it would be neat, if it was moved to a separate function (something like private void commitSolrChanges()).{quote} Sounds good, will update. {quote}We iterate over the appEntries and only the check the last element. Is it intended? If yes, then use appEntries.get(appEntries.size() - 1), if no, then move the assert into the for cycle to check every element.{quote} The test case only has one application. For loop isn't really necessary, and I will update to use appEntries.get(appEntries.size() -1) instead. Thanks > Add express upgrade button to Appcatalog UI > ------------------------------------------- > > Key: YARN-9281 > URL: https://issues.apache.org/jira/browse/YARN-9281 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Eric Yang > Assignee: Eric Yang > Priority: Major > Attachments: YARN-9281.001.patch, YARN-9281.002.patch, > YARN-9281.003.patch, YARN-9281.004.patch, YARN-9281.005.patch, > YARN-9281.006.patch > > > It would be nice to have ability to upgrade applications deployed by > Application catalog from Application catalog UI. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org