[ 
https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812437#comment-16812437
 ] 

Bibin A Chundatt commented on YARN-9460:
----------------------------------------

Thank you [~snemeth] for raising 

Consider ClientRMService#createAndPopulateNewRMApp scheduler instance of check 
also as part of this jira

> QueueACLsManager and ReservationsACLManager should not use instanceof checks
> ----------------------------------------------------------------------------
>
>                 Key: YARN-9460
>                 URL: https://issues.apache.org/jira/browse/YARN-9460
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Priority: Major
>
> QueueACLsManager and ReservationsACLManager should not use instanceof checks 
> for the scheduler type.
> Rather, we should abstract this into two classes: Capacity and Fair variants 
> of these ACL classes.
> QueueACLsManager and ReservationsACLManager could be abstract classes, but 
> the implementation is the decision of one who will work on this jira.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to