[
https://issues.apache.org/jira/browse/YARN-9470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818994#comment-16818994
]
Prabhu Joseph commented on YARN-9470:
-------------------------------------
Hi [~ajisakaa], Can you review this jira when you get time. This fixes
misplaced expected and actual args in {{assertEquals}} with AssertJ.
Failed testcases are not related - will be handled as part of YARN-9491 and
YARN-6272.
> Fix order of actual and expected expression in assert statements
> ----------------------------------------------------------------
>
> Key: YARN-9470
> URL: https://issues.apache.org/jira/browse/YARN-9470
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: yarn
> Affects Versions: 3.2.0
> Reporter: Prabhu Joseph
> Assignee: Prabhu Joseph
> Priority: Major
> Attachments: YARN-9470-001.patch, YARN-9470-002.patch,
> YARN-9470-003.patch, assertEquals
>
>
> Fix order of actual and expected expression in assert statements which gives
> misleading message when test case fails. Attached file has some of the places
> where it is placed wrongly.
> {code}
> [ERROR]
> testNodeRemovalGracefully(org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService)
> Time elapsed: 3.385 s <<< FAILURE!
> java.lang.AssertionError: Shutdown nodes should be 0 now expected:<1> but
> was:<0>
> {code}
> For long term, [AssertJ|http://joel-costigliola.github.io/assertj/] can be
> used for new test cases which avoids such mistakes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
