[
https://issues.apache.org/jira/browse/YARN-9440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825072#comment-16825072
]
Weiwei Yang commented on YARN-9440:
-----------------------------------
Hi [~Tao Yang]
Some more comments
RegularContainerAllocator#preCheckForNodeCandidateSet
it gets a PCDiagnosticsCollector and uses that to collect diaglosis info from
#precheckNode. However, precheck might fail with other reasons, not just PC
violation. I think it makes more sense to let precheckNode throw exception
instead of returning a bool value. So we can put a detail error message in the
exception. And use that for logging the activity too.
This patch modifies \{{ResourceCalculator}} base class, let's not do that. We
should keep RC class as it is, without adding {{ResourceDiagnosticsCollector}}
to any of method signatures. We can collect info outside of this class. Same
comment applies to \{{Resources}} too.
Thanks
> Improve diagnostics for scheduler and app activities
> ----------------------------------------------------
>
> Key: YARN-9440
> URL: https://issues.apache.org/jira/browse/YARN-9440
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacityscheduler
> Reporter: Tao Yang
> Assignee: Tao Yang
> Priority: Major
> Attachments: YARN-9440.001.patch, YARN-9440.002.patch
>
>
> [Design doc
> #4.1|https://docs.google.com/document/d/1pwf-n3BCLW76bGrmNPM4T6pQ3vC4dVMcN2Ud1hq1t2M/edit#heading=h.cyw6zeehzqmx]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
