[ 
https://issues.apache.org/jira/browse/YARN-9523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832746#comment-16832746
 ] 

Eric Badger commented on YARN-9523:
-----------------------------------

bq. Jonathan Eagles no one disputed against using "dist" profile for building 
docker image according to the email thread
The email thread wasn't about the use of the dist profile, though. So I don't 
think it's fair to say that their silence equals their implicit agreement. 

That being said, I think this is a more interesting conversation. I can see the 
argument around putting a docker image in the distribution profile. This would 
then spawn the conversation around whether or not we want to distribute a 
hadoop docker image at all. I'm not familiar on if such conversations have 
happened in the past. 

However, regardless of whether we want to build them or not, I don't think that 
we should break existing workflows that are building hadoop themselves and 
distributing the tarballs within their own companies. Fundamentally changing 
what the "dist" profile is does exactly that. I think that doing this in a 
minor release has the potential to cause a lot of headaches for people for 
something that is a new feature. I would rather that the minority of people 
adopting this new feature have to add a config option (e.g. -DBuildDocker) than 
forcing a larger group to have to change their current setup. 

> Build application catalog docker image as part of hadoop dist build
> -------------------------------------------------------------------
>
>                 Key: YARN-9523
>                 URL: https://issues.apache.org/jira/browse/YARN-9523
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>            Priority: Major
>         Attachments: YARN-9523.001.patch
>
>
> It would be nice to make Application catalog docker image as part of the 
> distribution.  The suggestion is to change from:
> {code:java}
> mvn clean package -Pnative,dist,docker{code}
> to
> {code:java}
> mvn clean package -Pnative,dist{code}
> User can still build tarball only using:
> {code:java}
> mvn clean package -DskipDocker -DskipTests -DskipShade -Pnative,dist{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to