[ 
https://issues.apache.org/jira/browse/YARN-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839812#comment-16839812
 ] 

Weiwei Yang commented on YARN-9497:
-----------------------------------

Thanks [~Tao Yang] for the updates, it looks good now. I have one minor comment 
about the query parameter, right now it is \{{groupingType}}, can we change it 
to \{{groupBy}}? And regarding the type, I think we can rename 
\{{STATE_AND_DIAGNOSTIC}} to \{{diagnostic}}, because I don't expect different 
activity state would have the same diagnostic messages, please correct me if I 
am wrong.

Another thing is, can we make sure we use "diagnostic" instead of all capital 
letters in the query parameter? Because that's the convention used in resource 
manager restful API.

Thanks

> Support grouping by diagnostics for query results of scheduler and app 
> activities
> ---------------------------------------------------------------------------------
>
>                 Key: YARN-9497
>                 URL: https://issues.apache.org/jira/browse/YARN-9497
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Tao Yang
>            Assignee: Tao Yang
>            Priority: Major
>         Attachments: YARN-9497.001.patch, YARN-9497.002.patch
>
>
> [Design Doc 
> #4.3|https://docs.google.com/document/d/1pwf-n3BCLW76bGrmNPM4T6pQ3vC4dVMcN2Ud1hq1t2M/edit#heading=h.6fbpge17dmmr]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to