[ https://issues.apache.org/jira/browse/YARN-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799721#comment-13799721 ]
Hadoop QA commented on YARN-1185: --------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12609245/YARN-1185.3.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 4 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/2226//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2226//console This message is automatically generated. > FileSystemRMStateStore can leave partial files that prevent subsequent > recovery > ------------------------------------------------------------------------------- > > Key: YARN-1185 > URL: https://issues.apache.org/jira/browse/YARN-1185 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Affects Versions: 2.1.0-beta > Reporter: Jason Lowe > Assignee: Omkar Vinit Joshi > Attachments: YARN-1185.1.patch, YARN-1185.2.patch, YARN-1185.3.patch > > > FileSystemRMStateStore writes directly to the destination file when storing > state. However if the RM were to crash in the middle of the write, the > recovery method could encounter a partially-written file and either outright > crash during recovery or silently load incomplete state. > To avoid this, the data should be written to a temporary file and renamed to > the destination file afterwards. -- This message was sent by Atlassian JIRA (v6.1#6144)