[
https://issues.apache.org/jira/browse/YARN-8199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852875#comment-16852875
]
Szilard Nemeth commented on YARN-8199:
--------------------------------------
Hi [~Prabhu Joseph]!
Thanks for this patch!
It looks good except one minor thingy:
In YarnConfiguration:
{code:java}
public static final long DEFAULT_LOG_AGGREGATION_DEBUG_FILESIZE = 104857600;
{code}
This is in bytes, right? Dividing this value by 1024 two times gives me 100, so
I guess this is equal to 100MB.
I would include the unit in the name of the constant (bytes).
Also, I would write the value as: 100 * 1024 * 1024;
Maybe you could put this comment to the same line: "100 MB, 104857600 bytes"
Thanks!
> Logging fileSize of log files under NM Local Dir
> ------------------------------------------------
>
> Key: YARN-8199
> URL: https://issues.apache.org/jira/browse/YARN-8199
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: log-aggregation
> Affects Versions: 2.7.3
> Reporter: Prabhu Joseph
> Assignee: Prabhu Joseph
> Priority: Major
> Labels: supportability
> Attachments: 0001-YARN-8199.patch, 0002-YARN-8199.patch
>
>
> Logging fileSize of log files like syslog, stderr, stdout under NM Local Dir
> by NodeManager before the cleanup will help to find the application which has
> written too verbose.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
