[ https://issues.apache.org/jira/browse/YARN-8995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866248#comment-16866248 ]
Tao Yang commented on YARN-8995: -------------------------------- Thanks [~zhuqi] for the update. You can either use "cc" or directly ping, it's necessary to use them both. Comments about the patch: * I just noticed that the printTrigger is placed before dispatching the event, I think we should move it backward to have more chance to catch the heavy event. * Type of AsyncDispatcher#LOG has changed from org.apache.commons.logging.Log to org.slf4j.Logger in trunk, can you rebase it from trunk again? * There are some lines without content or beyond 80 characters which should be adjusted. You can execute dev-support/bin/test-patch to validate the patch. > Log the event type of the too big AsyncDispatcher event queue size, and add > the information to the metrics. > ------------------------------------------------------------------------------------------------------------ > > Key: YARN-8995 > URL: https://issues.apache.org/jira/browse/YARN-8995 > Project: Hadoop YARN > Issue Type: Improvement > Components: metrics, nodemanager, resourcemanager > Affects Versions: 3.2.0 > Reporter: zhuqi > Assignee: zhuqi > Priority: Major > Attachments: TestStreamPerf.java, YARN-8995.001.patch, > YARN-8995.002.patch, YARN-8995.003.patch, YARN-8995.004.patch, > YARN-8995.005.patch > > > In our growing cluster,there are unexpected situations that cause some event > queues to block the performance of the cluster, such as the bug of > https://issues.apache.org/jira/browse/YARN-5262 . I think it's necessary to > log the event type of the too big event queue size, and add the information > to the metrics, and the threshold of queue size is a parametor which can be > changed. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org