[ https://issues.apache.org/jira/browse/YARN-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872696#comment-16872696 ]
Craig Condit commented on YARN-9560: ------------------------------------ [~eyang], making getRuntimeType() static would require the base class to be aware of all possible subclasses. This is extremely ugly. Might I suggest we table further changes to this patch and focus on the next one (the RunC patch itself)? I think getting something (even if not 100% perfect) in place so that we can iterate on functionality rather than form would be much more useful. I'm +1 as is on patch 10. LGTM. > Restructure DockerLinuxContainerRuntime to extend a new OCIContainerRuntime > --------------------------------------------------------------------------- > > Key: YARN-9560 > URL: https://issues.apache.org/jira/browse/YARN-9560 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Eric Badger > Assignee: Eric Badger > Priority: Major > Labels: Docker > Attachments: YARN-9560.001.patch, YARN-9560.002.patch, > YARN-9560.003.patch, YARN-9560.004.patch, YARN-9560.005.patch, > YARN-9560.006.patch, YARN-9560.007.patch, YARN-9560.008.patch, > YARN-9560.009.patch, YARN-9560.010.patch > > > Since the new RuncContainerRuntime will be using a lot of the same code as > DockerLinuxContainerRuntime, it would be good to move a bunch of the > DockerLinuxContainerRuntime code up a level to an abstract class that both of > the runtimes can extend. > The new structure will look like: > {noformat} > OCIContainerRuntime (abstract class) > - DockerLinuxContainerRuntime > - RuncContainerRuntime > {noformat} > This JIRA should only change the structure of the code, not the actual > semantics -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org